[SPARK-13495][SQL] Add Null Filters in the query plan for Filters/Joins based on their data constraints #11372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #51980 has finished for PR 11372 at commit
|
sameeragarwal
force-pushed
the
gen-isnotnull
branch
from
06d74da
to
2345075
Compare
|
Test build #51994 has finished for PR 11372 at commit
|
| .reduce(And) | ||
| Filter(reorderedCondition, child) | ||
| } | ||
| } |
There was a problem hiding this comment.
I am wondering if the optimizer is the right place for this rule. My main concern is that if we can preserve this ordering through the rest of query compilation. Will it be better to do it inside the physical Filter operator (just before we start to generate the code)?
There was a problem hiding this comment.
yes, that sounds like a good idea! Could there be any other downside of not doing it in the optimizer? /cc @nongli
sameeragarwal
force-pushed
the
gen-isnotnull
branch
from
2345075
to
c08b7fb
Compare
sameeragarwal
force-pushed
the
gen-isnotnull
branch
from
c08b7fb
to
28050b3
Compare
sameeragarwal
changed the title
|
Test build #52338 has finished for PR 11372 at commit
|
|
Test build #52383 has finished for PR 11372 at commit
|
|
Test build #52406 has finished for PR 11372 at commit
|
|
Test build #52416 has finished for PR 11372 at commit
|
|
test this please |
|
Test build #52431 has finished for PR 11372 at commit
|
| @@ -586,6 +587,52 @@ object NullPropagation extends Rule[LogicalPlan] { | |||
| } | |||
|
|
|||
| /** | |||
| * Attempts to eliminate reading (unnecessary) NULL values if they are not required for correctness | |||
| * by inserting isNotNull filters is the query plan. These filters are currently inserted beneath | |||
|
Thanks @nongli, all comments addressed. |
|
Test build #52494 has finished for PR 11372 at commit
|
|
LGTM |
roygao94
pushed a commit
to roygao94/spark
that referenced
this pull request
Mar 22, 2016
…ns based on their data constraints ## What changes were proposed in this pull request? This PR adds an optimizer rule to eliminate reading (unnecessary) NULL values if they are not required for correctness by inserting `isNotNull` filters is the query plan. These filters are currently inserted beneath existing `Filter` and `Join` operators and are inferred based on their data constraints. Note: While this optimization is applicable to all types of join, it primarily benefits `Inner` and `LeftSemi` joins. ## How was this patch tested? 1. Added a new `NullFilteringSuite` that tests for `IsNotNull` filters in the query plan for joins and filters. Also, tests interaction with the `CombineFilters` optimizer rules. 2. Test generated ExpressionTrees via `OrcFilterSuite` 3. Test filter source pushdown logic via `SimpleTextHadoopFsRelationSuite` cc yhuai nongli Author: Sameer Agarwal <sameer@databricks.com> Closes apache#11372 from sameeragarwal/gen-isnotnull.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR adds an optimizer rule to eliminate reading (unnecessary) NULL values if they are not required for correctness by inserting
isNotNullfilters is the query plan. These filters are currently inserted beneath existingFilterandJoinoperators and are inferred based on their data constraints.Note: While this optimization is applicable to all types of join, it primarily benefits
InnerandLeftSemijoins.How was this patch tested?
NullFilteringSuitethat tests forIsNotNullfilters in the query plan for joins and filters. Also, tests interaction with theCombineFiltersoptimizer rules.OrcFilterSuiteSimpleTextHadoopFsRelationSuitecc @yhuai @nongli