New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-11011][SQL] Narrow type of UDT serialization #11379
Conversation
@@ -50,11 +50,8 @@ abstract class UserDefinedType[UserType] extends DataType with Serializable { | |||
|
|||
/** | |||
* Convert the user type to a SQL datum | |||
* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might also be a good idea to update the documentation. In this case, what exactly is a SQL datum?
Test build #52006 has finished for PR 11379 at commit
|
Test build #52010 has finished for PR 11379 at commit
|
Latest commit only fixes a conflict in MiMa exclusion rules. Retesting should not be needed. |
Test build #52579 has finished for PR 11379 at commit
|
Whoops! Thanks for reminding me about the usefulness of testing, jenkins :) |
LGTM. Strange how cleaner Scala can fail the Scala style tests ;) |
It was actually a missing comma in an sbt file (MimaExcludes.scala in project/). Arguably a syntax error can be considered bad style ;) |
Test build #52584 has finished for PR 11379 at commit
|
Seems unrelated and works locally. Jenkins, retest this please. |
Test build #52600 has finished for PR 11379 at commit
|
+1. There was a bug in SQL internal type conversions, which might call @yhuai Could you make a final pass? |
LGTM |
Merged into master. Thanks! |
## What changes were proposed in this pull request? Narrow down the parameter type of `UserDefinedType#serialize()`. Currently, the parameter type is `Any`, however it would logically make more sense to narrow it down to the type of the actual user defined type. ## How was this patch tested? Existing tests were successfully run on local machine. Author: Jakob Odersky <jakob@odersky.com> Closes apache#11379 from jodersky/SPARK-11011-udt-types.
What changes were proposed in this pull request?
Narrow down the parameter type of
UserDefinedType#serialize()
. Currently, the parameter type isAny
, however it would logically make more sense to narrow it down to the type of the actual user defined type.How was this patch tested?
Existing tests were successfully run on local machine.