[SPARK-13512] [ML] add example and doc for MaxAbsScaler #11392
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #52048 has finished for PR 11392 at commit
|
|
Test build #52049 has finished for PR 11392 at commit
|
|
|
||
| import org.apache.spark.SparkConf; | ||
| import org.apache.spark.api.java.JavaSparkContext; | ||
| import org.apache.spark.ml.feature.MaxAbsScaler; |
There was a problem hiding this comment.
should we have $example on$ here (to match the JavaMinMaxScalerExample), i.e.
// $example on$
import org.apache.spark.ml.feature.MaxAbsScaler;
import org.apache.spark.ml.feature.MaxAbsScalerModel;
import org.apache.spark.sql.DataFrame;
// $example off$
|
@hhbyyh ping |
| // Compute summary statistics and generate MaxAbsScalerModel | ||
| MaxAbsScalerModel scalerModel = scaler.fit(dataFrame); | ||
|
|
||
| // rescale each feature to range [min, max]. |
There was a problem hiding this comment.
[min, max] should be [-1, 1].
|
@MLnick Thanks for helping review. Updated according to the comments. |
|
Test build #52836 has finished for PR 11392 at commit
|
|
Thanks! Merging to master. |
asfgit
pushed a commit
that referenced
this pull request
Mar 11, 2016
…xAbsScaler example ## What changes were proposed in this pull request? Fix build failure introduced in #11392 (change `DataFrame` -> `Dataset<Row>`). ## How was this patch tested? Existing build/unit tests Author: Nick Pentreath <nick.pentreath@gmail.com> Closes #11653 from MLnick/java-maxabs-example-fix.
roygao94
pushed a commit
to roygao94/spark
that referenced
this pull request
Mar 22, 2016
## What changes were proposed in this pull request? jira: https://issues.apache.org/jira/browse/SPARK-13512 Add example and doc for ml.feature.MaxAbsScaler. ## How was this patch tested? unit tests Author: Yuhao Yang <hhbyyh@gmail.com> Closes apache#11392 from hhbyyh/maxabsdoc.
roygao94
pushed a commit
to roygao94/spark
that referenced
this pull request
Mar 22, 2016
…xAbsScaler example ## What changes were proposed in this pull request? Fix build failure introduced in apache#11392 (change `DataFrame` -> `Dataset<Row>`). ## How was this patch tested? Existing build/unit tests Author: Nick Pentreath <nick.pentreath@gmail.com> Closes apache#11653 from MLnick/java-maxabs-example-fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
jira: https://issues.apache.org/jira/browse/SPARK-13512
Add example and doc for ml.feature.MaxAbsScaler.
How was this patch tested?
unit tests