[SPARK-13584][SQL][Tests]Make ContinuousQueryManagerSuite not output logs to the console #11439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -23,6 +23,7 @@ log4j.appender.CA=org.apache.log4j.ConsoleAppender | |||
| log4j.appender.CA.layout=org.apache.log4j.PatternLayout | |||
| log4j.appender.CA.layout.ConversionPattern=%d{HH:mm:ss.SSS} %p %c: %m%n | |||
| log4j.appender.CA.Threshold = WARN | |||
| log4j.appender.CA.follow = true | |||
There was a problem hiding this comment.
|
Test build #52204 has finished for PR 11439 at commit
|
|
cc @marmbrus for quick reviewing this small patch. |
| * System.out or System.err. Otherwise, ConsoleAppender will still output to the console even if | ||
| * we change System.out and System.err. | ||
| */ | ||
| private def testQuietly(name: String)(f: => Unit): Unit = { |
There was a problem hiding this comment.
Maybe we should put this somewhere more general?
|
LGTM |
|
Test build #52409 has finished for PR 11439 at commit
|
|
Merging to master. Thanks, @marmbrus |
roygao94
pushed a commit
to roygao94/spark
that referenced
this pull request
Mar 22, 2016
… logs to the console ## What changes were proposed in this pull request? Make ContinuousQueryManagerSuite not output logs to the console. The logs will still output to `unit-tests.log`. I also updated `SQLListenerMemoryLeakSuite` to use `quietly` to avoid changing the log level which won't output logs to `unit-tests.log`. ## How was this patch tested? Just check Jenkins output. Author: Shixiong Zhu <shixiong@databricks.com> Closes apache#11439 from zsxwing/quietly-ContinuousQueryManagerSuite.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Make ContinuousQueryManagerSuite not output logs to the console. The logs will still output to
unit-tests.log.I also updated
SQLListenerMemoryLeakSuiteto usequietlyto avoid changing the log level which won't output logs tounit-tests.log.How was this patch tested?
Just check Jenkins output.