[SPARK-13647][SQL] also check if numeric value is within allowed range in _verify_type #11492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #52391 has finished for PR 11492 at commit
|
| from struct import pack, unpack | ||
|
|
||
| if not isinf(obj): | ||
| f = unpack("f", pack("f", obj))[0] |
There was a problem hiding this comment.
Here I try to convert the obj to binary string as a float32, and then convert it back. If it becomes an inf, then it means the obj can not fit in float32.
Is there a better way to check if a python float can fit in float32?
There was a problem hiding this comment.
I'm worried that this will be super slow, I think we don't need this.
If overflow happens, it will become infinity.
|
Test build #52436 has finished for PR 11492 at commit
|
|
LGTM |
|
Merging this into master, thanks! |
roygao94
pushed a commit
to roygao94/spark
that referenced
this pull request
Mar 22, 2016
…ge in _verify_type ## What changes were proposed in this pull request? This PR makes the `_verify_type` in `types.py` more strict, also check if numeric value is within allowed range. ## How was this patch tested? newly added doc test. Author: Wenchen Fan <wenchen@databricks.com> Closes apache#11492 from cloud-fan/py-verify.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR makes the
_verify_typeintypes.pymore strict, also check if numeric value is within allowed range.How was this patch tested?
newly added doc test.