Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-13423] [HOTFIX] Static analysis fixes for 2.x / fixed for Scala 2.10, again #11496

Closed
wants to merge 1 commit into from

Conversation

srowen
Copy link
Member

@srowen srowen commented Mar 3, 2016

What changes were proposed in this pull request?

Fixes (another) compile problem due to inadvertent use of Option.contains, only in Scala 2.11

How was this patch tested?

Jenkins tests

@SparkQA
Copy link

SparkQA commented Mar 3, 2016

Test build #52398 has finished for PR 11496 at commit d798022.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member Author

srowen commented Mar 3, 2016

Jenkins retest this please

@SparkQA
Copy link

SparkQA commented Mar 3, 2016

Test build #52399 has finished for PR 11496 at commit d798022.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member Author

srowen commented Mar 3, 2016

Ugh, this is blocking me from dropping in this fix for 2.10. The test failures are virtually certainly spurious; different both times, and the change here is logically equivalent. I'll spin it one more time since the build failure for 2.10 isn't technically blocking something

@srowen
Copy link
Member Author

srowen commented Mar 3, 2016

Jenkins, retest this please

@SparkQA
Copy link

SparkQA commented Mar 3, 2016

Test build #52407 has finished for PR 11496 at commit d798022.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member Author

srowen commented Mar 3, 2016

Merged to master. FFS

@srowen srowen closed this Mar 3, 2016
@srowen srowen deleted the SPARK-13423.3 branch March 3, 2016 22:41
srowen added a commit to srowen/spark that referenced this pull request Mar 3, 2016
… 2.10, again

## What changes were proposed in this pull request?

Fixes (another) compile problem due to inadvertent use of Option.contains, only in Scala 2.11

## How was this patch tested?

Jenkins tests

Author: Sean Owen <sowen@cloudera.com>

Closes apache#11496 from srowen/SPARK-13423.3.
roygao94 pushed a commit to roygao94/spark that referenced this pull request Mar 22, 2016
… 2.10, again

## What changes were proposed in this pull request?

Fixes (another) compile problem due to inadvertent use of Option.contains, only in Scala 2.11

## How was this patch tested?

Jenkins tests

Author: Sean Owen <sowen@cloudera.com>

Closes apache#11496 from srowen/SPARK-13423.3.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants