[SPARK-13668][SQL] Reorder filter/join predicates to short-circuit isNotNull checks #11511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #52447 has finished for PR 11511 at commit
|
|
|
||
| // Attempts to re-order the individual conjunctive predicates in an expression to short circuit | ||
| // the evaluation of relatively cheaper checks (e.g., checking for nullability) before others. | ||
| protected def getReorderedExpression(expr: Expression): Expression = { |
There was a problem hiding this comment.
nit: i think this is more aptly named "reorderPredicates"
|
LGTM |
sameeragarwal
force-pushed
the
reorder-isnotnull
branch
from
d75d313
to
4a8a9a3
Compare
|
Thanks, comments addressed. |
|
Test build #52487 has finished for PR 11511 at commit
|
|
Test build #52488 has finished for PR 11511 at commit
|
|
|
||
| // Attempts to re-order the individual conjunctive predicates in an expression to short circuit | ||
| // the evaluation of relatively cheaper checks (e.g., checking for nullability) before others. | ||
| protected def reorderPredicates(expr: Expression): Expression = { |
There was a problem hiding this comment.
Can we have a test to make sure this reordering is stable?
There was a problem hiding this comment.
Thanks, I modified the 2 tests in ReorderPredicateSuite to verify that the sort is stable.
sameeragarwal
force-pushed
the
reorder-isnotnull
branch
from
4a8a9a3
to
21d8897
Compare
|
Test build #52692 has finished for PR 11511 at commit
|
|
LGTM. Merging to master. |
roygao94
pushed a commit
to roygao94/spark
that referenced
this pull request
Mar 22, 2016
…NotNull checks ## What changes were proposed in this pull request? If a filter predicate or a join condition consists of `IsNotNull` checks, we should reorder these checks such that these non-nullability checks are evaluated before the rest of the predicates. For e.g., if a filter predicate is of the form `a > 5 && isNotNull(b)`, we should rewrite this as `isNotNull(b) && a > 5` during physical plan generation. ## How was this patch tested? new unit tests that verify the physical plan for both filters and joins in `ReorderedPredicateSuite` Author: Sameer Agarwal <sameer@databricks.com> Closes apache#11511 from sameeragarwal/reorder-isnotnull.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
If a filter predicate or a join condition consists of
IsNotNullchecks, we should reorder these checks such that these non-nullability checks are evaluated before the rest of the predicates.For e.g., if a filter predicate is of the form
a > 5 && isNotNull(b), we should rewrite this asisNotNull(b) && a > 5during physical plan generation.How was this patch tested?
new unit tests that verify the physical plan for both filters and joins in
ReorderedPredicateSuite