[SPARK-13715] [MLLIB] Remove last usages of jblas in tests #11560
Conversation
|
Test build #52561 has finished for PR 11560 at commit
|
|
LGTM, a quick grep for jblas showed that every last reference to it is now gone. |
|
Heh yeah I just need to get the tests passing. I think it's the random seed differences. |
| MatrixFactorizationModel model, | ||
| int users, | ||
| int products, | ||
| DoubleMatrix trueRatings, | ||
| double[] trueRatings, |
There was a problem hiding this comment.
For the record, this is not a DenseMatrix<Double> because the Scala method this relies on returns a DenseMatrix<Object> as far as Java is concerned. It ended up being easier just to make this private test method pass around an array, I think.
|
Test build #52667 has finished for PR 11560 at commit
|
|
I'm gonna go for it since this is a test-only change and it passes |
## What changes were proposed in this pull request? Remove last usage of jblas, in tests ## How was this patch tested? Jenkins tests -- the same ones that are being modified. Author: Sean Owen <sowen@cloudera.com> Closes apache#11560 from srowen/SPARK-13715.
|
Sean, any plans to backport this and https://issues.apache.org/jira/browse/SPARK-5814 to the 1.6 branch? Happy to test and contribute myself in a new JIRA if need be |
|
I hadn't planned on it because it is not a bug fix, so normally doesn't go in a maintenance release |
What changes were proposed in this pull request?
Remove last usage of jblas, in tests
How was this patch tested?
Jenkins tests -- the same ones that are being modified.