improve the doc for "spark.memory.offHeap.size" #11561
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I didn't create a JIRA as I think it is not necessary....if the reviewer still prefers with a JIRA, I can add one |
|
Test build #52564 has finished for PR 11561 at commit
|
|
@srowen mind reviewing it? |
| @@ -769,7 +769,7 @@ Apart from these, the following properties are also available, and may be useful | |||
| <td><code>spark.memory.offHeap.size</code></td> | |||
| <td>0</td> | |||
| <td> | |||
| The absolute amount of memory which can be used for off-heap allocation. | |||
| The absolute amount of memory (in terms by bytes) which can be used for off-heap allocation. | |||
There was a problem hiding this comment.
just "... memory in bytes which ..." is sufficient. "terms by bytes" doesn't work. Yes it's fine.
|
Test build #52577 has finished for PR 11561 at commit
|
|
LGTM. Merging to master and 1.6. |
asfgit
pushed a commit
that referenced
this pull request
Mar 7, 2016
The description of "spark.memory.offHeap.size" in the current document does not clearly state that memory is counted with bytes.... This PR contains a small fix for this tiny issue document fix Author: CodingCat <zhunansjtu@gmail.com> Closes #11561 from CodingCat/master. (cherry picked from commit a3ec50a) Signed-off-by: Shixiong Zhu <shixiong@databricks.com>
|
Thanks, @CodingCat |
roygao94
pushed a commit
to roygao94/spark
that referenced
this pull request
Mar 22, 2016
The description of "spark.memory.offHeap.size" in the current document does not clearly state that memory is counted with bytes.... This PR contains a small fix for this tiny issue document fix Author: CodingCat <zhunansjtu@gmail.com> Closes apache#11561 from CodingCat/master.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The description of "spark.memory.offHeap.size" in the current document does not clearly state that memory is counted with bytes....
This PR contains a small fix for this tiny issue
How was this patch tested?
document fix