[SPARK-13711][Core]Don't call SparkUncaughtExceptionHandler in AppClient as it's in driver #11566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @vanzin as you added |
|
Actually it seems it was @markhamstra and not me (in 17f3075). |
|
@vanzin Sorry. I was looking a wrong place... |
|
So what happens now if the scheduled Runnable throws an exception? |
Just go to |
| registerMasterFutures.get.foreach(_.cancel(true)) | ||
| registerMasterThreadPool.shutdownNow() | ||
| } else if (nthRetry >= REGISTRATION_RETRIES) { | ||
| markDead("All masters are unresponsive! Giving up.") |
There was a problem hiding this comment.
FYI, this line will call sc.stop(): https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/scheduler/cluster/SparkDeploySchedulerBackend.scala#L136
|
LGTM |
|
Test build #52609 has finished for PR 11566 at commit
|
|
Thanks. Merging to master and 1.6 |
asfgit
pushed a commit
that referenced
this pull request
Mar 8, 2016
…ient as it's in driver ## What changes were proposed in this pull request? AppClient runs in the driver side. It should not call `Utils.tryOrExit` as it will send exception to SparkUncaughtExceptionHandler and call `System.exit`. This PR just removed `Utils.tryOrExit`. ## How was this patch tested? manual tests. Author: Shixiong Zhu <shixiong@databricks.com> Closes #11566 from zsxwing/SPARK-13711.
roygao94
pushed a commit
to roygao94/spark
that referenced
this pull request
Mar 22, 2016
…ient as it's in driver ## What changes were proposed in this pull request? AppClient runs in the driver side. It should not call `Utils.tryOrExit` as it will send exception to SparkUncaughtExceptionHandler and call `System.exit`. This PR just removed `Utils.tryOrExit`. ## How was this patch tested? manual tests. Author: Shixiong Zhu <shixiong@databricks.com> Closes apache#11566 from zsxwing/SPARK-13711.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
AppClient runs in the driver side. It should not call
Utils.tryOrExitas it will send exception to SparkUncaughtExceptionHandler and callSystem.exit. This PR just removedUtils.tryOrExit.How was this patch tested?
manual tests.