[SPARK-13400] Stop using deprecated Octal escape literals #11584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -71,7 +71,7 @@ class HiveQlSuite extends SparkFunSuite with BeforeAndAfterAll { | |||
| CatalogColumn("dt", "string", comment = Some("date type")) :: | |||
| CatalogColumn("hour", "string", comment = Some("hour of the day")) :: Nil) | |||
| assert(desc.storage.serdeProperties == | |||
| Map((serdeConstants.SERIALIZATION_FORMAT, "\054"), (serdeConstants.FIELD_DELIM, "\054"))) | |||
| Map((serdeConstants.SERIALIZATION_FORMAT, "\u002C"), (serdeConstants.FIELD_DELIM, "\u002C"))) | |||
There was a problem hiding this comment.
maybe i'm not understanding this correctly, but isn't 2C = 44?
There was a problem hiding this comment.
So "\u002C" == "\054" returns true, and 054 is in octal which is 44 in decimal.
|
LGTM pending tests. |
|
LGTM pending tests, we should of course do a quick search in the resulting build log and make sure no octal warnings show up but these are the two I had seen when building locally. |
|
Looking at the build logs no Octal deprecation warnings - (still waiting on the tests to finish but build part finished) :) |
|
Thank you for confirming that, @holdenk ! :) |
|
Test build #52685 has finished for PR 11584 at commit
|
|
At last, it passed and there is no |
|
Thanks - merging in master. |
roygao94
pushed a commit
to roygao94/spark
that referenced
this pull request
Mar 22, 2016
## What changes were proposed in this pull request? This removes the remaining deprecated Octal escape literals. The followings are the warnings on those two lines. ``` LiteralExpressionSuite.scala:99: Octal escape literals are deprecated, use \u0000 instead. HiveQlSuite.scala:74: Octal escape literals are deprecated, use \u002c instead. ``` ## How was this patch tested? Manual. During building, there should be no warning on `Octal escape literals`. ``` mvn -DskipTests clean install ``` Author: Dongjoon Hyun <dongjoon@apache.org> Closes apache#11584 from dongjoon-hyun/SPARK-13400.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This removes the remaining deprecated Octal escape literals. The followings are the warnings on those two lines.
How was this patch tested?
Manual.
During building, there should be no warning on
Octal escape literals.