Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix minor tempo in 'hypot' docstring #11616

Closed
wants to merge 1 commit into from

Conversation

tristanreid
Copy link
Contributor

What changes were proposed in this pull request?

Minor typo: docstring for pyspark.sql.functions: hypot has extra characters

How was this patch tested?

N/A

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@andrewor14
Copy link
Contributor

Merged into master.

@asfgit asfgit closed this in 5f7dbdb Mar 10, 2016
@srowen
Copy link
Member

srowen commented Mar 10, 2016

That's entirely fine, but I note that some people intentionally write ^2^ instead of ^2 (not me). You can see both occurrences throughout the code base. Ideally we'd standardize rather than flip one to the other in one case.

@tristanreid
Copy link
Contributor Author

Oh interesting, I hadn't noticed that. Wonder if it has significance for typesetting or something, like:
x^i+1^
I'll do some research on this - If there's no technical reason to prefer it and if you're amenable I'll grep for the other occurrences and standardize?

@srowen
Copy link
Member

srowen commented Mar 10, 2016

I don't recognize the syntax either, and it's not LaTeX. I don't think it's worth standardizing. For whatever reason I see people write this frequently.

roygao94 pushed a commit to roygao94/spark that referenced this pull request Mar 22, 2016
Minor typo:  docstring for pyspark.sql.functions: hypot has extra characters

N/A

Author: Tristan Reid <treid@netflix.com>

Closes apache#11616 from tristanreid/master.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants