Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SQL][TEST] Increased timeouts to reduce flakiness in ContinuousQueryManagerSuite #11638

Closed
wants to merge 1 commit into from

Conversation

tdas
Copy link
Contributor

@tdas tdas commented Mar 10, 2016

What changes were proposed in this pull request?

ContinuousQueryManager is sometimes flaky on Jenkins. I could not reproduce it on my machine, so I guess it about the waiting times which causes problems if Jenkins is loaded. I have increased the wait time in the hope that it will be less flaky.

How was this patch tested?

I reran the unit test many times on a loop in my machine. I am going to run it a few time in Jenkins, that's the real test.

@tdas
Copy link
Contributor Author

tdas commented Mar 10, 2016

@zsxwing

@tdas tdas changed the title Increased timeouts to reduce flakiness [SQL][TEST] Increased timeouts to reduce flakiness in ContinuousQueryManagerSuite Mar 10, 2016
@zsxwing
Copy link
Member

zsxwing commented Mar 10, 2016

retest this please

@yhuai
Copy link
Contributor

yhuai commented Mar 10, 2016

The PR builder has passed ContinuousQueryManagerSuite. I am merging this to master.

@asfgit asfgit closed this in 3d2b6f5 Mar 10, 2016
@SparkQA
Copy link

SparkQA commented Mar 10, 2016

Test build #52854 has finished for PR 11638 at commit 5ab7fee.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Mar 11, 2016

Test build #52860 has finished for PR 11638 at commit 5ab7fee.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

roygao94 pushed a commit to roygao94/spark that referenced this pull request Mar 22, 2016
…ManagerSuite

## What changes were proposed in this pull request?

ContinuousQueryManager is sometimes flaky on Jenkins. I could not reproduce it on my machine, so I guess it about the waiting times which causes problems if Jenkins is loaded. I have increased the wait time in the hope that it will be less flaky.

## How was this patch tested?

I reran the unit test many times on a loop in my machine. I am going to run it a few time in Jenkins, that's the real test.

Author: Tathagata Das <tathagata.das1565@gmail.com>

Closes apache#11638 from tdas/cqm-flaky-test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants