[SPARK-13833] Guard against race condition when re-caching disk blocks in memory #11660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshRosen
changed the title
|
/cc @andrewor14. In addition to fixing that race-condition, this patch also addresses that duplicated code that you pointed out in a review of my previous PR. |
| * Attempts to cache spilled bytes read from disk into the MemoryStore in order to speed up | ||
| * subsequent reads. This method requires the caller to hold a read lock on the block. | ||
| * | ||
| * @return a copy of the bytes. The original byes passed this method should no longer |
|
Test build #52953 has finished for PR 11660 at commit
|
|
Test build #52965 has finished for PR 11660 at commit
|
|
@andrewor14 did you have any other comments here or is this ready to merge? |
|
Sorry, merging now. |
jeanlyn
pushed a commit
to jeanlyn/spark
that referenced
this pull request
Mar 17, 2016
…s in memory When reading data from the DiskStore and attempting to cache it back into the memory store, we should guard against race conditions where multiple readers are attempting to re-cache the same block in memory. This patch accomplishes this by synchronizing on the block's `BlockInfo` object while trying to re-cache a block. (Will file JIRA as soon as ASF JIRA stops being down / laggy). Author: Josh Rosen <joshrosen@databricks.com> Closes apache#11660 from JoshRosen/concurrent-recaching-fixes.
roygao94
pushed a commit
to roygao94/spark
that referenced
this pull request
Mar 22, 2016
…s in memory When reading data from the DiskStore and attempting to cache it back into the memory store, we should guard against race conditions where multiple readers are attempting to re-cache the same block in memory. This patch accomplishes this by synchronizing on the block's `BlockInfo` object while trying to re-cache a block. (Will file JIRA as soon as ASF JIRA stops being down / laggy). Author: Josh Rosen <joshrosen@databricks.com> Closes apache#11660 from JoshRosen/concurrent-recaching-fixes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reading data from the DiskStore and attempting to cache it back into the memory store, we should guard against race conditions where multiple readers are attempting to re-cache the same block in memory.
This patch accomplishes this by synchronizing on the block's
BlockInfoobject while trying to re-cache a block.(Will file JIRA as soon as ASF JIRA stops being down / laggy).