[SPARK-13139][SQL] Follow-ups to #11573 #11667
Conversation
|
Test build #52967 has finished for PR 11667 at commit
|
|
LGTM |
| @@ -36,6 +36,18 @@ private[sql] class SparkQl(conf: ParserConf = SimpleParserConf()) extends Cataly | |||
| /** | |||
| * For each node, extract properties in the form of a list ['key1', 'key2', 'key3', 'value'] | |||
| * into a pair (key1.key2.key3, value). | |||
| * | |||
There was a problem hiding this comment.
Not very related to this PR. @hvanhovell Do you know when we will have something like
TOK_TABLEPROPERTY
'key_part1'
'key_part2'
'key_part3'
'value'
(the form that matches the original comment extract properties in the form of a list ['key1', 'key2', 'key3', 'value'] into a pair (key1.key2.key3, value).)
There was a problem hiding this comment.
That happens when we have a dot-separated key, e.g.: a.b.c The parser identifies each part of the identifier separately, e.g: a, b & c. It is a bit of a PITA to re-construct this in ANTLR3, so we currently do this in the tree parser.
There was a problem hiding this comment.
@andrewor14 I will change For each node, extract properties in the form of a list ['key1', 'key2', 'key3', 'value'] into a pair (key1.key2.key3, value). to For each node, extract properties in the form of a list ['key_part1', 'key_part2', 'key_part3', 'value'] into a pair (key_part1.key_part2.key_part3, value).. Hopefully, this will make the comment easier to understand.
|
LGTM. I am merging this to master. |
Addressing outstanding comments in apache#11573. Jenkins, new test case in `DDLCommandSuite` Author: Andrew Or <andrew@databricks.com> Closes apache#11667 from andrewor14/ddl-parser-followups.
Addressing outstanding comments in apache#11573. Jenkins, new test case in `DDLCommandSuite` Author: Andrew Or <andrew@databricks.com> Closes apache#11667 from andrewor14/ddl-parser-followups.
What changes were proposed in this pull request?
Addressing outstanding comments in #11573.
How was this patch tested?
Jenkins, new test case in
DDLCommandSuite