[SPARK-13893][SQL] Remove SQLContext.catalog/analyzer (internal method) #11716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @cloud-fan one more ... |
| @@ -113,8 +113,6 @@ class HiveContext private[hive]( | |||
| @transient | |||
| protected[sql] override lazy val sessionState = new HiveSessionState(self) | |||
|
|
|||
| protected[sql] override def catalog = sessionState.catalog | |||
There was a problem hiding this comment.
looks like this is the last one :)
There was a problem hiding this comment.
there are more actually ... in sqlcontext
|
LGTM |
rxin
changed the title
|
@cloud-fan Had an extra minute - I went ahead and removed analyzer as well. |
|
LGTM |
|
Test build #53177 has finished for PR 11716 at commit
|
|
Test build #53174 has finished for PR 11716 at commit
|
|
Thanks - merging in master. |
roygao94
pushed a commit
to roygao94/spark
that referenced
this pull request
Mar 22, 2016
## What changes were proposed in this pull request? Our internal code can go through SessionState.catalog and SessionState.analyzer. This brings two small benefits: 1. Reduces internal dependency on SQLContext. 2. Removes 2 public methods in Java (Java does not obey package private visibility). More importantly, according to the design in SPARK-13485, we'd need to claim this catalog function for the user-facing public functions, rather than having an internal field. ## How was this patch tested? Existing unit/integration test code. Author: Reynold Xin <rxin@databricks.com> Closes apache#11716 from rxin/SPARK-13893.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Our internal code can go through SessionState.catalog and SessionState.analyzer. This brings two small benefits:
More importantly, according to the design in SPARK-13485, we'd need to claim this catalog function for the user-facing public functions, rather than having an internal field.
How was this patch tested?
Existing unit/integration test code.