[SPARK-13898][SQL] Merge DatasetHolder and DataFrameHolder #11737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #53211 has finished for PR 11737 at commit
|
|
Test build #53210 has finished for PR 11737 at commit
|
|
Test build #53215 has finished for PR 11737 at commit
|
|
Test build #53272 has finished for PR 11737 at commit
|
|
Test build #53394 has finished for PR 11737 at commit
|
|
@jodersky there are still two failures here. I probably won't have time to look at it until next week. If you have some time, please go for it! I think some are legitimate bugs in dataset encoders exposed by this change. |
|
cc @cloud-fan can you take a look at the failure for failing to serialize? The exception is After changing the toString of GetStructField to the following: A different exception appears: |
| @@ -729,7 +729,7 @@ class SQLQuerySuite extends QueryTest with SQLTestUtils with TestHiveSingleton { | |||
| } | |||
|
|
|||
| test("SPARK-5203 union with different decimal precision") { | |||
| Seq.empty[(Decimal, Decimal)] | |||
| Seq.empty[(java.math.BigDecimal, java.math.BigDecimal)] | |||
There was a problem hiding this comment.
Are all these decimal related changes because merging DataFrameHolder and DatasetHolder breaks compilation, or just because Decimal is internal type and shouldn't be exposed?
There was a problem hiding this comment.
Decimal's an internal type. (although I think we should expose it in the future -- but we haven't done that yet)
|
PR #11816, which fixes this exception you hit, has been merged. |
|
Test build #53687 has finished for PR 11737 at commit
|
|
Test build #53705 has finished for PR 11737 at commit
|
|
LGTM |
|
Merging in master. |
|
Test build #2655 has finished for PR 11737 at commit
|
roygao94
pushed a commit
to roygao94/spark
that referenced
this pull request
Mar 22, 2016
## What changes were proposed in this pull request? This patch merges DatasetHolder and DataFrameHolder. This makes more sense because DataFrame/Dataset are now one class. In addition, fixed some minor issues with pull request apache#11732. ## How was this patch tested? Updated existing unit tests that test these implicits. Author: Reynold Xin <rxin@databricks.com> Closes apache#11737 from rxin/SPARK-13898.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This patch merges DatasetHolder and DataFrameHolder. This makes more sense because DataFrame/Dataset are now one class.
In addition, fixed some minor issues with pull request #11732.
How was this patch tested?
Updated existing unit tests that test these implicits.