[SPARK-13930][SQL] Apply fast serialization on collect limit operator #11759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #53309 has finished for PR 11759 at commit
|
|
retest this please. |
|
Test build #53310 has finished for PR 11759 at commit
|
|
Test build #53320 has finished for PR 11759 at commit
|
| * Runs this query returning the result as an array. | ||
| * Packing the UnsafeRows into byte array for faster serialization. | ||
| * The byte arrays are in the following format: | ||
| * [size] [bytes of UnsafeRow] [size] [bytes of UnsafeRow] ... [-1] |
There was a problem hiding this comment.
This is the implementation details, it has nothing with the APIs, I'd like to keep these as comments.
There was a problem hiding this comment.
nvm, you make it as an function.
|
Test build #53501 has finished for PR 11759 at commit
|
|
Test build #53502 has finished for PR 11759 at commit
|
|
cc @davies The comments are addressed and tests are passed. Please see if this is ok now. Thanks! |
|
LGTM, merging this into master, thanks! |
roygao94
pushed a commit
to roygao94/spark
that referenced
this pull request
Mar 22, 2016
## What changes were proposed in this pull request? JIRA: https://issues.apache.org/jira/browse/SPARK-13930 Recently the fast serialization has been introduced to collecting DataFrame/Dataset (apache#11664). The same technology can be used on collect limit operator too. ## How was this patch tested? Add a benchmark for collect limit to `BenchmarkWholeStageCodegen`. Without this patch: model name : Westmere E56xx/L56xx/X56xx (Nehalem-C) collect limit: Best/Avg Time(ms) Rate(M/s) Per Row(ns) Relative ------------------------------------------------------------------------------------------- collect limit 1 million 3413 / 3768 0.3 3255.0 1.0X collect limit 2 millions 9728 / 10440 0.1 9277.3 0.4X With this patch: model name : Westmere E56xx/L56xx/X56xx (Nehalem-C) collect limit: Best/Avg Time(ms) Rate(M/s) Per Row(ns) Relative ------------------------------------------------------------------------------------------- collect limit 1 million 833 / 1284 1.3 794.4 1.0X collect limit 2 millions 3348 / 4005 0.3 3193.3 0.2X Author: Liang-Chi Hsieh <simonh@tw.ibm.com> Closes apache#11759 from viirya/execute-take.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
JIRA: https://issues.apache.org/jira/browse/SPARK-13930
Recently the fast serialization has been introduced to collecting DataFrame/Dataset (#11664). The same technology can be used on collect limit operator too.
How was this patch tested?
Add a benchmark for collect limit to
BenchmarkWholeStageCodegen.Without this patch:
With this patch: