[SPARK-13972][SQ] hive tests should fail if SQL generation failed #11782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @liancheng @yhuai |
|
Test build #53428 has finished for PR 11782 at commit
|
|
@cloud-fan Let's mark this PR as WIP and use this branch to fix detected SQL generation failures. I'll open PRs directly to this branch. |
|
Once we have gong through the failed tests, can we make a summary (on root causes of failed tests)? |
cloud-fan
changed the title
|
retest this please |
|
Test build #53524 has finished for PR 11782 at commit
|
|
retest this please |
|
Test build #53535 has finished for PR 11782 at commit
|
|
retest this please |
|
Test build #53538 has finished for PR 11782 at commit
|
cloud-fan
changed the title
|
Merging to master. |
roygao94
pushed a commit
to roygao94/spark
that referenced
this pull request
Mar 22, 2016
## What changes were proposed in this pull request? Now we should be able to convert all logical plans to SQL string, if they are parsed from hive query. This PR changes the error handling to throw exceptions instead of just log. We will send new PRs for spotted bugs, and merge this one after all bugs are fixed. ## How was this patch tested? existing tests. Author: Wenchen Fan <wenchen@databricks.com> Closes apache#11782 from cloud-fan/test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Now we should be able to convert all logical plans to SQL string, if they are parsed from hive query. This PR changes the error handling to throw exceptions instead of just log.
We will send new PRs for spotted bugs, and merge this one after all bugs are fixed.
How was this patch tested?
existing tests.