[SPARK-13761] [ML] Remove remaining uses of validateParams #11790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC: @hhbyyh Could you please take a look at this? Thanks! |
|
Looks good. |
| @@ -31,6 +32,7 @@ private[ml] trait ValidatorParams extends Params { | |||
|
|
|||
| /** | |||
| * param for the estimator to be validated | |||
| * | |||
There was a problem hiding this comment.
Not sure if this is intentional. But it's OK.
There was a problem hiding this comment.
Not intentional, just IntelliJ. I'll leave it though.
|
Test build #53447 has finished for PR 11790 at commit
|
|
@hhbyyh Thanks for reviewing it! I'll merge it with master |
roygao94
pushed a commit
to roygao94/spark
that referenced
this pull request
Mar 22, 2016
## What changes were proposed in this pull request? Cleanups from [apache#11620]: remove remaining uses of validateParams, and put functionality into transformSchema ## How was this patch tested? Existing unit tests, modified to check using transformSchema instead of validateParams Author: Joseph K. Bradley <joseph@databricks.com> Closes apache#11790 from jkbradley/SPARK-13761-cleanup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Cleanups from [https://github.com//pull/11620]: remove remaining uses of validateParams, and put functionality into transformSchema
How was this patch tested?
Existing unit tests, modified to check using transformSchema instead of validateParams