[SPARK-12719][HOTFIX] Fix compilation against Scala 2.10

[yy2016]

What changes were proposed in this pull request?

Compilation against Scala 2.10 fails with:
[error] [warn] /home/jenkins/workspace/spark-master-compile-sbt-scala-2.10/sql/hive/src/main/scala/org/apache/spark/sql/hive/SQLBuilder.scala:483: Cannot check match for unreachability. [error] (The analysis required more space than allowed. Please try with scalac -Dscalac.patmat.analysisBudget=512 or -Dscalac.patmat.analysisBudget=off.) [error] [warn] private def addSubqueryIfNeeded(plan: LogicalPlan): LogicalPlan = plan match {

This PR increases patmat.analysisBudget

How was this patch tested?

Compilation against Scala 2.10

[yy2016]

@JoshRosen
See if this is better.

[JoshRosen]

Why not pass it to scalacOptions instead of setting a system property? https://github.com/yy2016/spark/blob/master/project/SparkBuild.scala#L194

[yhuai]

ok to test

[JoshRosen]

Note that the PR builder won't actually test this against 2.10, so we'll still need to check this out and test it ourselves before merge.

[yhuai]

let me test this

[yhuai]

I tested locally. Unfortunately, it did not fix the problem.

[SparkQA]

Test build #53485 has finished for PR 11798 at commit a5403b1.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[yy2016]

See if this is good.

I can modify the description when I get confirmation.

[SparkQA]

Test build #53493 has finished for PR 11798 at commit bd37dcf.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[liancheng]

@JoshRosen It seems that tuning scalac.patmat.analysisBudget doesn't work for this case. According to Scala compiler code, -Dscalac.patmat.analysisBudget=off is equivalent to setting this option to Integer.MAX_VALUE, but this error is still there. I think we should merge this case-expansion fix first to bring master SBT build back.

@yy2016 I'm merging this to master, will update the commit message while merging. Thanks for the fix!

[liancheng]

@yy2016 Updated commit message:

PR #11696 introduced a complex pattern match that broke Scala 2.10 match unreachability check and caused build failure. This PR fixes this issue by expanding this pattern match into several simpler ones.

Note that tuning or turning off -Dscalac.patmat.analysisBudget doesn't work for this case.

Compilation against Scala 2.10

[SparkQA]

Test build #53492 has finished for PR 11798 at commit f13abe8.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.