[SPARK-10680][Tests]Increase 'connectionTimeout' to make RequestTimeoutIntegrationSuite more stable #11833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @yhuai |
| @@ -121,7 +121,7 @@ public StreamManager getStreamManager() { | |||
| // Second times out after 2 seconds, with slack. Must be IOException. | |||
| TestCallback callback1 = new TestCallback(); | |||
| client.sendRpc(ByteBuffer.allocate(0), callback1); | |||
| callback1.latch.await(4, TimeUnit.SECONDS); | |||
| callback1.latch.await(60, TimeUnit.SECONDS); | |||
There was a problem hiding this comment.
Does the commend Second times out after 2 seconds, with slack. Must be IOException. mean anything to the value that we put at here?
|
Test build #53573 has finished for PR 11833 at commit
|
|
Test build #53618 has finished for PR 11833 at commit
|
|
LGTM. Merging to master. |
roygao94
pushed a commit
to roygao94/spark
that referenced
this pull request
Mar 22, 2016
…outIntegrationSuite more stable ## What changes were proposed in this pull request? Increase 'connectionTimeout' to make RequestTimeoutIntegrationSuite more stable ## How was this patch tested? Existing unit tests Author: Shixiong Zhu <shixiong@databricks.com> Closes apache#11833 from zsxwing/SPARK-10680.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Increase 'connectionTimeout' to make RequestTimeoutIntegrationSuite more stable
How was this patch tested?
Existing unit tests