Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-13949][ML][PYTHON] PySpark ml DecisionTreeClassifier, Regressor support export/import #11892

Closed
wants to merge 3 commits into from

Conversation

GayathriMurali
Copy link
Contributor

What changes were proposed in this pull request?

Added MLReadable and MLWritable to Decision Tree Classifier and Regressor. Added doctests.

How was this patch tested?

Python Unit tests. Tests added to check persistence in DecisionTreeClassifier and DecisionTreeRegressor.

@GayathriMurali
Copy link
Contributor Author

@jkbradley Can you please review this patch?

@jkbradley
Copy link
Member

Yes, I'll take a look now

@jkbradley
Copy link
Member

ok to test

@jkbradley
Copy link
Member

LGTM pending tests

Could you please fix the PR title to include the ML and Python tags: "[SPARK-13949][ML][PYTHON] ..."? Thanks!

@SparkQA
Copy link

SparkQA commented Mar 23, 2016

Test build #2670 has finished for PR 11892 at commit 0154444.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class DecisionTreeClassificationModel(DecisionTreeModel, MLWritable, MLReadable):
    • class DecisionTreeModel(JavaModel, MLWritable, MLReadable):

@@ -454,7 +466,7 @@ def _create_model(self, java_model):


@inherit_doc
class DecisionTreeModel(JavaModel):
class DecisionTreeModel(JavaModel, MLWritable, MLReadable):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I didn't spot this. This class should be left alone, and DecisionTreeRegressionModel can be modified instead.

@jkbradley
Copy link
Member

OH! I think another issue is a PR which was merged yesterday which conflicts (silently) with this PR. Can you please merge with master?

@GayathriMurali
Copy link
Contributor Author

@jkbradley This test is not starting automatically. Can you please issue the ok to test again?

@jkbradley
Copy link
Member

add to whitelist

@SparkQA
Copy link

SparkQA commented Mar 24, 2016

Test build #2675 has finished for PR 11892 at commit bad5c3e.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@GayathriMurali GayathriMurali changed the title [SPARK-13949] PySpark ml DecisionTreeClassifier, Regressor support export/import [SPARK-13949][ML][PYTHON] PySpark ml DecisionTreeClassifier, Regressor support export/import Mar 24, 2016
@mengxr
Copy link
Contributor

mengxr commented Mar 25, 2016

Merged into master. Thanks!

@asfgit asfgit closed this in 0874ff3 Mar 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants