New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-13949][ML][PYTHON] PySpark ml DecisionTreeClassifier, Regressor support export/import #11892
Conversation
@jkbradley Can you please review this patch? |
Yes, I'll take a look now |
ok to test |
LGTM pending tests Could you please fix the PR title to include the ML and Python tags: "[SPARK-13949][ML][PYTHON] ..."? Thanks! |
Test build #2670 has finished for PR 11892 at commit
|
@@ -454,7 +466,7 @@ def _create_model(self, java_model): | |||
|
|||
|
|||
@inherit_doc | |||
class DecisionTreeModel(JavaModel): | |||
class DecisionTreeModel(JavaModel, MLWritable, MLReadable): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, I didn't spot this. This class should be left alone, and DecisionTreeRegressionModel can be modified instead.
OH! I think another issue is a PR which was merged yesterday which conflicts (silently) with this PR. Can you please merge with master? |
@jkbradley This test is not starting automatically. Can you please issue the ok to test again? |
add to whitelist |
Test build #2675 has finished for PR 11892 at commit
|
Merged into master. Thanks! |
What changes were proposed in this pull request?
Added MLReadable and MLWritable to Decision Tree Classifier and Regressor. Added doctests.
How was this patch tested?
Python Unit tests. Tests added to check persistence in DecisionTreeClassifier and DecisionTreeRegressor.