Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-13010] [ML] [SparkR] Implement a simple wrapper of AFTSurvivalRegression in SparkR #11932

Closed
wants to merge 5 commits into from

Conversation

yanboliang
Copy link
Contributor

What changes were proposed in this pull request?

This PR continues the work in #11447, we implemented the wrapper of AFTSurvivalRegression named survreg in SparkR.

How was this patch tested?

Test against output from R package survival's survreg.

cc @mengxr @felixcheung

Close #11447

@SparkQA
Copy link

SparkQA commented Mar 24, 2016

Test build #54031 has finished for PR 11932 at commit e6cc821.

  • This patch fails SparkR unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Mar 24, 2016

Test build #54038 has finished for PR 11932 at commit dc64aaa.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

}
})

test_that("survreg2", {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test case is for review only, to show an example of SparkR::survreg vs survival::survreg. Will remove if merged.

@mengxr
Copy link
Contributor

mengxr commented Mar 24, 2016

@yanboliang The implementation looks good to me. Please update the PR and remove the survreg2 test.

@felixcheung
Copy link
Member

Right - it's nice to see if we have similar interface.

This test we are keeping, it passes locally when you have survival package as

model <- survreg(formula = survival::Surv(time, status) ~ x + sex, data = rData)

ie. without survival:: namespace in front of survreg?

It is preferred that we don't mask/conflict with other packages if possible.

@mengxr
Copy link
Contributor

mengxr commented Mar 24, 2016

@felixcheung It works without survival:: because survreg is a regular function, like glm. If it is an S3 generic method like naiveBayes, we have to use the namespace prefix.

@SparkQA
Copy link

SparkQA commented Mar 25, 2016

Test build #54139 has finished for PR 11932 at commit 9023a92.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@mengxr
Copy link
Contributor

mengxr commented Mar 25, 2016

LGTM. Merged into master. Thanks!

@asfgit asfgit closed this in 13cbb2d Mar 25, 2016
@yanboliang yanboliang deleted the spark-13010-new branch March 25, 2016 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants