New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-13010] [ML] [SparkR] Implement a simple wrapper of AFTSurvivalRegression in SparkR #11932
Conversation
Test build #54031 has finished for PR 11932 at commit
|
Test build #54038 has finished for PR 11932 at commit
|
} | ||
}) | ||
|
||
test_that("survreg2", { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test case is for review only, to show an example of SparkR::survreg
vs survival::survreg
. Will remove if merged.
@yanboliang The implementation looks good to me. Please update the PR and remove the |
Right - it's nice to see if we have similar interface. This test we are keeping, it passes locally when you have
ie. without It is preferred that we don't mask/conflict with other packages if possible. |
@felixcheung It works without |
Test build #54139 has finished for PR 11932 at commit
|
LGTM. Merged into master. Thanks! |
What changes were proposed in this pull request?
This PR continues the work in #11447, we implemented the wrapper of
AFTSurvivalRegression
namedsurvreg
in SparkR.How was this patch tested?
Test against output from R package survival's survreg.
cc @mengxr @felixcheung
Close #11447