[Spark-14138][SQL][master] Fix generated SpecificColumnarIterator code can exceed JVM size limit for cached DataFrames #12108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiszk
changed the title
|
Test build #54697 has finished for PR 12108 at commit
|
|
Jenkins, retest this please |
|
Test build #54700 has finished for PR 12108 at commit
|
|
@davies , created PR for master |
|
LGTM, merging into master. |
| @@ -114,6 +114,42 @@ object GenerateColumnAccessor extends CodeGenerator[Seq[DataType], ColumnarItera | |||
| (createCode, extract + patch) | |||
| }.unzip | |||
|
|
|||
| /* | |||
| * 200 = 6000 bytes / 30 (up to 30 bytes per one call)) | |||
| * the maximum byte code size to be compiled for HotSpot is 8000. | |||
There was a problem hiding this comment.
Can you give me link to the above limit of 8000 ?
The answer to http://stackoverflow.com/questions/11345034/how-many-bytes-of-bytecode-has-a-particular-method-in-java seems to show a different limit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR reduces Java byte code size of method in
SpecificColumnarIteratorby using a approach to make a group for lot ofColumnAccessorinstantiations or method calls (more than 200) into a methodHow was this patch tested?
Added a new unit test, which includes large instantiations and method calls, to
InMemoryColumnarQuerySuite