-
Notifications
You must be signed in to change notification settings - Fork 28k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-14426][SQL] Merge PerserUtils and ParseUtils #12199
Closed
Closed
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
135 changes: 0 additions & 135 deletions
135
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/parser/ParseUtils.java
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
65 changes: 65 additions & 0 deletions
65
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/ParserUtilsSuite.scala
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,65 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one or more | ||
* contributor license agreements. See the NOTICE file distributed with | ||
* this work for additional information regarding copyright ownership. | ||
* The ASF licenses this file to You under the Apache License, Version 2.0 | ||
* (the "License"); you may not use this file except in compliance with | ||
* the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
package org.apache.spark.sql.catalyst.parser | ||
|
||
import org.apache.spark.SparkFunSuite | ||
|
||
class ParserUtilsSuite extends SparkFunSuite { | ||
|
||
import ParserUtils._ | ||
|
||
test("unescapeSQLString") { | ||
// scalastyle:off nonascii | ||
|
||
// String not including escaped characters and enclosed by double quotes. | ||
assert(unescapeSQLString(""""abcdefg"""") == "abcdefg") | ||
|
||
// String enclosed by single quotes. | ||
assert(unescapeSQLString("""'C0FFEE'""") == "C0FFEE") | ||
|
||
// Strings including single escaped characters. | ||
assert(unescapeSQLString("""'\0'""") == "\u0000") | ||
assert(unescapeSQLString(""""\'"""") == "\'") | ||
assert(unescapeSQLString("""'\"'""") == "\"") | ||
assert(unescapeSQLString(""""\b"""") == "\b") | ||
assert(unescapeSQLString("""'\n'""") == "\n") | ||
assert(unescapeSQLString(""""\r"""") == "\r") | ||
assert(unescapeSQLString("""'\t'""") == "\t") | ||
assert(unescapeSQLString(""""\Z"""") == "\u001A") | ||
assert(unescapeSQLString("""'\\'""") == "\\") | ||
assert(unescapeSQLString(""""\%"""") == "\\%") | ||
assert(unescapeSQLString("""'\_'""") == "\\_") | ||
|
||
// String including '\000' style literal characters. | ||
assert(unescapeSQLString("""'3 + 5 = \070'""") == "3 + 5 = \u0038") | ||
assert(unescapeSQLString(""""\000"""") == "\u0000") | ||
|
||
// String including invalid '\000' style literal characters. | ||
assert(unescapeSQLString(""""\256"""") == "256") | ||
|
||
// String including a '\u0000' style literal characters (\u732B is a cat in Kanji). | ||
assert(unescapeSQLString(""""How cute \u732B are"""") == "How cute \u732B are") | ||
|
||
// String including a surrogate pair character | ||
// (\uD867\uDE3D is Okhotsk atka mackerel in Kanji). | ||
assert(unescapeSQLString(""""\uD867\uDE3D is a fish"""") == "\uD867\uDE3D is a fish") | ||
|
||
// scalastyle:on nonascii | ||
} | ||
|
||
// TODO: Add test cases for other methods in ParserUtils | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah you have a point there. These methods are all tested indirectly in the
*ParserSuite
's.