[SPARK-14506] [SQL] HiveClientImpl's toHiveTable misses a table property for external tables #12275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rty for external tables
|
Test build #55441 has finished for PR 12275 at commit
|
|
test this please |
|
Test build #55444 has finished for PR 12275 at commit
|
|
test this please |
|
Test build #55448 has finished for PR 12275 at commit
|
|
@andrewor14 want to review this? |
| hiveTable.setProperty("EXTERNAL", "TRUE") | ||
| HiveTableType.EXTERNAL_TABLE | ||
| case CatalogTableType.MANAGED_TABLE => | ||
| hiveTable.setProperty("EXTERNAL", "FALSE") |
There was a problem hiding this comment.
we don't ned to set this to false in other cases?
There was a problem hiding this comment.
Looks like we do not need to set it for other cases. This flag is only used for MANAGED_TABLE and EXTERNAL_TABLE.
|
LGTM |
|
Merged into master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
For an external table's metadata (in Hive's representation), its table type needs to be EXTERNAL_TABLE. Also, there needs to be a field called EXTERNAL set in the table property with a value of TRUE (for a MANAGED_TABLE it will be FALSE) based on https://github.com/apache/hive/blob/release-1.2.1/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java#L1095-L1105. HiveClientImpl's toHiveTable misses to set this table property.
How was this patch tested?
Added a new test.