Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-14514][DOC] Add python example for VectorSlicer #12282

Closed
wants to merge 1 commit into from

Conversation

zhengruifeng
Copy link
Contributor

What changes were proposed in this pull request?

Add the missing python example for VectorSlicer

How was this patch tested?

manual tests

@SparkQA
Copy link

SparkQA commented Apr 10, 2016

Test build #55465 has finished for PR 12282 at commit 1b139c7.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@holdenk
Copy link
Contributor

holdenk commented Apr 11, 2016

So this one differs slightly from the Scala example, it might make sense to have a follow JIRA for once/if AttributeGroup is exposed in Python to also update this example. What do you think?

@zhengruifeng
Copy link
Contributor Author

@holdenk I agree with you. Python wrapper for AttributeGroup is missing now.

@holdenk
Copy link
Contributor

holdenk commented Apr 19, 2016

Rad, maybe @jkbradley can take a look at this PR?

@jkbradley
Copy link
Member

test this please

@jkbradley
Copy link
Member

LGTM pending an updated run of the tests

I agree we can update this later after Attributes are exposed in Python. We want to re-evaluate the attribute/metadata API first.

@SparkQA
Copy link

SparkQA commented Apr 26, 2016

Test build #57027 has finished for PR 12282 at commit 1b139c7.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@jkbradley
Copy link
Member

Merging with master
Thanks @zhengruifeng !

@asfgit asfgit closed this in e88476c Apr 26, 2016
@zhengruifeng zhengruifeng deleted the vecslicer_pe branch April 26, 2016 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants