Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-14407][SQL] Hides HadoopFsRelation related data source API into execution/datasources package #12178 #12361

Closed

Conversation

liancheng
Copy link
Contributor

What changes were proposed in this pull request?

This PR moves HadoopFsRelation related data source API into execution/datasources package.

Note that to avoid conflicts, this PR is based on #12153. Effective changes for this PR only consist of the last three commits. Will rebase after merging #12153.

How was this patch tested?

Existing tests.

@SparkQA
Copy link

SparkQA commented Apr 13, 2016

Test build #55720 has finished for PR 12361 at commit ba71c95.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Apr 14, 2016

Test build #55791 has finished for PR 12361 at commit 673352e.

  • This patch fails Scala style tests.
  • This patch does not merge cleanly.
  • This patch adds no public classes.

@liancheng liancheng force-pushed the spark-14407-hide-hadoop-fs-relation branch 2 times, most recently from 712505f to 4221aca Compare April 14, 2016 12:40
@SparkQA
Copy link

SparkQA commented Apr 14, 2016

Test build #55814 has finished for PR 12361 at commit 4221aca.

  • This patch fails from timeout after a configured wait of 250m.
  • This patch merges cleanly.
  • This patch adds no public classes.

@liancheng liancheng force-pushed the spark-14407-hide-hadoop-fs-relation branch from 4221aca to 5db3662 Compare April 19, 2016 12:51
@SparkQA
Copy link

SparkQA commented Apr 19, 2016

Test build #56223 has finished for PR 12361 at commit 5db3662.

  • This patch passes all tests.
  • This patch does not merge cleanly.
  • This patch adds the following public classes (experimental):
    • case class FilePartition(index: Int, files: Seq[PartitionedFile]) extends RDDPartition
    • abstract class OutputWriterFactory extends Serializable
    • abstract class OutputWriter
    • case class HadoopFsRelation(
    • trait FileFormat
    • case class Partition(values: InternalRow, files: Seq[FileStatus])
    • trait FileCatalog
    • class HDFSFileCatalog(
    • case class FakeFileStatus(

@SparkQA
Copy link

SparkQA commented Apr 19, 2016

Test build #56257 has finished for PR 12361 at commit 340f304.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@yhuai
Copy link
Contributor

yhuai commented Apr 19, 2016

test this please

@SparkQA
Copy link

SparkQA commented Apr 19, 2016

Test build #56277 has finished for PR 12361 at commit 340f304.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@yhuai
Copy link
Contributor

yhuai commented Apr 20, 2016

Thanks! @liancheng I am going to merge this.

@asfgit asfgit closed this in 10f273d Apr 20, 2016
* @return
*/
def buildReader(
sqlContext: SQLContext,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need @param for this ?

@liancheng liancheng deleted the spark-14407-hide-hadoop-fs-relation branch May 3, 2016 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants