[SPARK-14668] [SQL] Move CurrentDatabase to Catalyst #12424
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @ExpressionDescription( | ||
| usage = "_FUNC_() - Returns the current database.", | ||
| extended = "> SELECT _FUNC_()") | ||
| private[sql] case class CurrentDatabase(ctx: SQLContext) |
There was a problem hiding this comment.
i'm afraid this is too convoluted -- why don't we just have this function not taking any arguments, and then in the optimizer (which should take a SessionState) replace it with a literal? similar to how we compute CurrentDate.
There was a problem hiding this comment.
sure, but this is just moving code. We can clean that up later
|
Test build #55955 has finished for PR 12424 at commit
|
|
Test build #55953 has finished for PR 12424 at commit
|
yhuai
changed the title
|
Test build #55971 has finished for PR 12424 at commit
|
|
This conflicts with mine - but I can redo mine #12434 |
|
Merging in master. |
lw-lin
pushed a commit
to lw-lin/spark
that referenced
this pull request
Apr 20, 2016
## What changes were proposed in this pull request?
This PR moves `CurrentDatabase` from sql/hive package to sql/catalyst. It also adds the function description, which looks like the following.
```
scala> sqlContext.sql("describe function extended current_database").collect.foreach(println)
[Function: current_database]
[Class: org.apache.spark.sql.execution.command.CurrentDatabase]
[Usage: current_database() - Returns the current database.]
[Extended Usage:
> SELECT current_database()]
```
## How was this patch tested?
Existing tests
Author: Yin Huai <yhuai@databricks.com>
Closes apache#12424 from yhuai/SPARK-14668.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR moves
CurrentDatabasefrom sql/hive package to sql/catalyst. It also adds the function description, which looks like the following.How was this patch tested?
Existing tests