Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-13745][SQL]Support columnar in memory representation on Big Endian platforms - implement by subclassing #12501

Closed
wants to merge 9 commits into from

Conversation

robbinspg
Copy link
Member

What changes were proposed in this pull request?

An alternative implementation of #12397 which uses subclasses to minimize any potential performance hits on Little Endian

parquet datasource and ColumnarBatch tests fail on big-endian platforms This patch adds support for the little-endian byte arrays being correctly interpreted on a big-endian platform

How was this patch tested?

Spark test builds ran on big endian z/Linux and regression build on little endian amd64

@robbinspg robbinspg changed the title [SPARK-13745][SQL]Support columnar in memory representation on Big Endian platforms - implent by subclassing [SPARK-13745][SQL]Support columnar in memory representation on Big Endian platforms - implement by subclassing Apr 19, 2016
@SparkQA
Copy link

SparkQA commented Apr 19, 2016

Test build #2830 has finished for PR 12501 at commit 648b7ac.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@robbinspg
Copy link
Member Author

closing this in favour of other implementation

@robbinspg robbinspg closed this Apr 23, 2016
@robbinspg robbinspg deleted the bigEndianViaSubclass branch May 5, 2016 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants