[SPARK-14591] [SQL] Remove DataTypeParser and add more keywords to the nonReserved list. #12796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #57388 has finished for PR 12796 at commit
|
| @@ -674,6 +674,8 @@ nonReserved | |||
| | AT | NULLS | OVERWRITE | ALL | ALTER | AS | BETWEEN | BY | CREATE | DELETE | |||
| | DESCRIBE | DROP | EXISTS | FALSE | FOR | GROUP | IN | INSERT | INTO | IS |LIKE | |||
| | NULL | ORDER | OUTER | TABLE | TRUE | WITH | RLIKE | |||
| | AND | CASE | CAST | CROSS | DISTINCT | DIV | ELSE | END | FROM | FUNCTION | HAVING | INTERVAL | JOIN| | |||
There was a problem hiding this comment.
cc @hvanhovell
Does adding things to this list cause any problems (performance?)?
| @@ -674,6 +674,8 @@ nonReserved | |||
| | AT | NULLS | OVERWRITE | ALL | ALTER | AS | BETWEEN | BY | CREATE | DELETE | |||
| | DESCRIBE | DROP | EXISTS | FALSE | FOR | GROUP | IN | INSERT | INTO | IS |LIKE | |||
| | NULL | ORDER | OUTER | TABLE | TRUE | WITH | RLIKE | |||
| | AND | CASE | CAST | CROSS | DISTINCT | DIV | ELSE | END | FROM | FUNCTION | HAVING | INTERVAL | JOIN | |||
| | MACRO | NOT | ON | OR | SELECT | STRATIFY | THEN | UNBOUNDED | WHEN | WHERE | |||
There was a problem hiding this comment.
From @rxin
cc @hvanhovell
Does adding things to this list cause any problems (performance?)?
|
Test build #57392 has finished for PR 12796 at commit
|
|
I have reverted the parser change. Since It's still good to only have a single parser to avoid any potential confusion. |
|
Test build #57406 has finished for PR 12796 at commit
|
|
Thanks - merging in master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
CatalystSqlParser can parse data types. So, we do not need to have an individual DataTypeParser.
How was this patch tested?
Existing tests