[SPARK-15134][EXAMPLE] Indent SparkSession builder patterns and update binary_classification_metrics_example.py #12911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ry_classification_metrics_example.py
|
Hi, @andrewor14 . |
| streamId, | ||
| msg.blockIds.length, | ||
| client.getClientId(), | ||
| NettyUtils.getRemoteAddress(client.getChannel())); |
There was a problem hiding this comment.
ok, but in the future I would keep unrelated changes separate
There was a problem hiding this comment.
Oh, I see. I'll keep it in mind.
|
Test build #57809 has finished for PR 12911 at commit
|
|
retest this please |
|
Test build #57826 has finished for PR 12911 at commit
|
|
Merging into master 2.0. Thanks! |
asfgit
pushed a commit
that referenced
this pull request
May 5, 2016
…e binary_classification_metrics_example.py ## What changes were proposed in this pull request? This issue addresses the comments in SPARK-15031 and also fix java-linter errors. - Use multiline format in SparkSession builder patterns. - Update `binary_classification_metrics_example.py` to use `SparkSession`. - Fix Java Linter errors (in SPARK-13745, SPARK-15031, and so far) ## How was this patch tested? After passing the Jenkins tests and run `dev/lint-java` manually. Author: Dongjoon Hyun <dongjoon@apache.org> Closes #12911 from dongjoon-hyun/SPARK-15134. (cherry picked from commit 2c170dd) Signed-off-by: Andrew Or <andrew@databricks.com>
|
Thank you, @andrewor14 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This issue addresses the comments in SPARK-15031 and also fix java-linter errors.
binary_classification_metrics_example.pyto useSparkSession.How was this patch tested?
After passing the Jenkins tests and run
dev/lint-javamanually.