[SPARK-15290] [BUILD] Move annotations, like @Since / @DeveloperApi, into spark-tags #13074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #58464 has finished for PR 13074 at commit
|
|
Test build #58476 has finished for PR 13074 at commit
|
|
Test build #58478 has finished for PR 13074 at commit
|
|
Test build #58480 has finished for PR 13074 at commit
|
|
cc @JoshRosen |
|
I'm going to proceed with this since it's better to get it done for 2.0 and enable easier management of annotations going forward. We essentially reviewed this in #12416 and it unblocks SPARK-14613, marked for 2.0 |
|
Actually josh is on vacation. Definitely go ahead. I looked at it and it seemed ok. I'm not a build expert though. |
|
Merged to master/2.0 |
asfgit
pushed a commit
that referenced
this pull request
May 17, 2016
…nto spark-tags ## What changes were proposed in this pull request? (See #12416 where most of this was already reviewed and committed; this is just the module structure and move part. This change does not move the annotations into test scope, which was the apparently problem last time.) Rename `spark-test-tags` -> `spark-tags`; move common annotations like `Since` to `spark-tags` ## How was this patch tested? Jenkins tests. Author: Sean Owen <sowen@cloudera.com> Closes #13074 from srowen/SPARK-15290. (cherry picked from commit 122302c) Signed-off-by: Sean Owen <sowen@cloudera.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
(See #12416 where most of this was already reviewed and committed; this is just the module structure and move part. This change does not move the annotations into test scope, which was the apparently problem last time.)
Rename
spark-test-tags->spark-tags; move common annotations like@Sincetospark-tagsHow was this patch tested?
Jenkins tests.