[SPARK-15297] [SQL] Fix Set -V Command #13081
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #58506 has finished for PR 13081 at commit
|
|
@andrewor14 @yhuai @rxin Could you please review this PR? Thanks! |
|
Test build #58610 has finished for PR 13081 at commit
|
|
ping @hvanhovell @cloud-fan Do you have a bandwidth to review this simple fix? Thanks! |
|
retest this please |
|
Test build #58817 has finished for PR 13081 at commit
|
asfgit
pushed a commit
that referenced
this pull request
May 19, 2016
#### What changes were proposed in this pull request? The command `SET -v` always outputs the default values even if we set the parameter. This behavior is incorrect. Instead, if users override it, we should output the user-specified value. In addition, the output schema of `SET -v` is wrong. We should use the column `value` instead of `default` for the parameter value. This PR is to fix the above two issues. #### How was this patch tested? Added a test case. Author: gatorsmile <gatorsmile@gmail.com> Closes #13081 from gatorsmile/setVcommand. (cherry picked from commit 9c2a376) Signed-off-by: Wenchen Fan <wenchen@databricks.com>
|
LGTM, merging to master and 2.0! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The command
SET -valways outputs the default values even if we set the parameter. This behavior is incorrect. Instead, if users override it, we should output the user-specified value.In addition, the output schema of
SET -vis wrong. We should use the columnvalueinstead ofdefaultfor the parameter value.This PR is to fix the above two issues.
How was this patch tested?
Added a test case.