Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-15171][SQL] Remove the references to deprecated method dataset.registerTempTable #13098

Closed
wants to merge 7 commits into from
Closed

[SPARK-15171][SQL] Remove the references to deprecated method dataset.registerTempTable #13098

wants to merge 7 commits into from

Conversation

clockfly
Copy link
Contributor

@clockfly clockfly commented May 13, 2016 •
edited

What changes were proposed in this pull request?

Update the unit test code, examples, and documents to remove calls to deprecated method dataset.registerTempTable.

How was this patch tested?

This PR only changes the unit test code, examples, and comments. It should be safe.
This is a follow up of PR #12945 which was merged.

@SparkQA
Copy link

SparkQA commented May 13, 2016

Test build #58556 has finished for PR 13098 at commit 513ace1.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented May 13, 2016

Test build #58558 has finished for PR 13098 at commit 53aa395.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented May 13, 2016

Test build #58559 has finished for PR 13098 at commit 5842188.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented May 13, 2016

Test build #58561 has finished for PR 13098 at commit 1aa763e.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@clockfly clockfly force-pushed the spark-15171-remove-deprecation branch from 1aa763e to d1ba75b Compare May 13, 2016 09:51
@SparkQA
Copy link

SparkQA commented May 13, 2016

Test build #58564 has finished for PR 13098 at commit d1ba75b.

  • This patch fails Python style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@clockfly clockfly force-pushed the spark-15171-remove-deprecation branch from d1ba75b to 304902c Compare May 13, 2016 09:57
@SparkQA
Copy link

SparkQA commented May 13, 2016

Test build #58567 has finished for PR 13098 at commit 304902c.

  • This patch fails Python style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@clockfly clockfly force-pushed the spark-15171-remove-deprecation branch from 304902c to a7165f2 Compare May 13, 2016 11:16
@SparkQA
Copy link

SparkQA commented May 13, 2016

Test build #58571 has finished for PR 13098 at commit a7165f2.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@gatorsmile gatorsmile mentioned this pull request May 16, 2016
Closed
liancheng
liancheng reviewed May 16, 2016
View reviewed changes
docs/sql-programming-guide.md
@@ -703,8 +703,8 @@ val rowRDD = people.map(_.split(",")).map(p => Row(p(0), p(1).trim))
// Apply the schema to the RDD.
val peopleDataFrame = sqlContext.createDataFrame(rowRDD, schema)

// Register the DataFrames as a table.
peopleDataFrame.registerTempTable("people")
// Creates a temporary view.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Creates a temporary view using the DataFrame

@liancheng
Copy link
Contributor

liancheng commented May 16, 2016 •
edited

Please update the PR title and description since it also removes deprecated call from examples and docs.

liancheng
liancheng reviewed May 16, 2016
View reviewed changes
sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
@@ -1975,9 +1978,9 @@ class SQLQuerySuite extends QueryTest with SharedSQLContext {
nestedStructData.select($"record.r1.*"),
Row(1, 1) :: Row(1, 2) :: Row(2, 1) :: Row(2, 2) :: Row(3, 1) :: Row(3, 2) :: Nil)

// Try with a registered table
// Try with a temporary view
withTempTable("nestedStructTable") {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also rename this utility method?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can do it in follow-ups though.

@liancheng
Copy link
Contributor

LGTM except for some minor comments.

@clockfly clockfly changed the title [SPARK-15171][SQL] Update unit tests to remove the references to deprecated method dataset.registerTempTable [SPARK-15171][SQL] Remove the references to deprecated method dataset.registerTempTable May 18, 2016
@asfgit asfgit closed this in 25b315e May 18, 2016
@liancheng
Copy link
Contributor

Just merged this to master, but it conflicts with branch-2.0. Trying to resolve manually.

@liancheng
Copy link
Contributor

Also merged to branch-2.0.

asfgit pushed a commit that referenced this pull request May 18, 2016
@clockfly @liancheng
[SPARK-15171][SQL] Remove the references to deprecated method dataset…
5f5270e 
….registerTempTable

## What changes were proposed in this pull request?

Update the unit test code, examples, and documents to remove calls to deprecated method `dataset.registerTempTable`.

## How was this patch tested?

This PR only changes the unit test code, examples, and comments. It should be safe.
This is a follow up of PR #12945 which was merged.

Author: Sean Zhong <seanzhong@databricks.com>

Closes #13098 from clockfly/spark-15171-remove-deprecation.

(cherry picked from commit 25b315e)
Signed-off-by: Cheng Lian <lian@databricks.com>
@SparkQA
Copy link

SparkQA commented May 18, 2016

Test build #58730 has finished for PR 13098 at commit 2029f51.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented May 18, 2016

Test build #58731 has finished for PR 13098 at commit 47a3cb2.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@gatorsmile gatorsmile mentioned this pull request Nov 16, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@clockfly @SparkQA @liancheng