[SPARK-15331] [SQL] Disallow All the Unsupported CLI Commands #13122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #58612 has finished for PR 13122 at commit
|
|
Test build #58614 has finished for PR 13122 at commit
|
| @@ -172,6 +172,10 @@ unsupportedHiveNativeCommands | |||
| | kw1=ROLLBACK | |||
| | kw1=DFS | |||
| | kw1=DELETE kw2=FROM | |||
| | kw1=RELOAD kw2=FUNCTION | |||
| | kw1=DELETE kw2=(FILE | FILES | JAR | JARS | ARCHIVE | ARCHIVES) | |||
There was a problem hiding this comment.
Could you perhaps do this without adding the FILE, FILES, JAR, JARS, ARCHIVE & ARCHIVES keywords? This makes it consistent with the ADD <resource> command.
|
Test build #58839 has finished for PR 13122 at commit
|
|
Test build #58841 has finished for PR 13122 at commit
|
# Conflicts: # sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 # sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala # sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLCLIDriver.scala
|
@hvanhovell @yhuai This is also ready to review. Thanks! |
|
Test build #59568 has finished for PR 13122 at commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The JIRAs under https://issues.apache.org/jira/browse/SPARK-14118 remove the support of the DDL/CLI commands that are not natively supported by Spark. However, in Spark-SQL CLI, we still delegate the CLI commands to Hive command processors. To be consistent, we should also remove the related command supports in Spark SQL CLI.
Also, we need to improve Parser to issue better error exception messages for these unsupported operations.
How was this patch tested?
Added a test case in CliSuite.