[SPARK-15334][SQL] HiveClient facade not compatible with Hive 0.12 #13127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #58621 has finished for PR 13127 at commit
|
| inputFormat = Some(classOf[org.apache.hadoop.mapred.TextInputFormat].getName), | ||
| outputFormat = Some( | ||
| classOf[org.apache.hadoop.hive.ql.io.HiveIgnoreKeyTextOutputFormat[_, _]].getName), | ||
| serde = Some(classOf[org.apache.hadoop.hive.serde2.`lazy`.LazySimpleSerDe].getName()), |
There was a problem hiding this comment.
How about importing these Hive classes above instead of using the fully qualified names here?
|
I have finished my review. Thank you for working on this! |
|
Test build #58739 has finished for PR 13127 at commit
|
|
Test build #58747 has finished for PR 13127 at commit
|
|
Test build #58748 has finished for PR 13127 at commit
|
|
LGTM, merging to master and branch-2.0. |
asfgit
pushed a commit
that referenced
this pull request
May 18, 2016
## What changes were proposed in this pull request? HiveClient facade is not compatible with Hive 0.12. This PR Fixes the following compatibility issues: 1. `org.apache.spark.sql.hive.client.HiveClientImpl` use `AddPartitionDesc(db, table, ignoreIfExists)` to create partitions, however, Hive 0.12 doesn't have this constructor for `AddPartitionDesc`. 2. `HiveClientImpl` uses `PartitionDropOptions` when dropping partition, however, class `PartitionDropOptions` doesn't exist in Hive 0.12. 3. Hive 0.12 doesn't support adding permanent functions. It is not valid to call `org.apache.hadoop.hive.ql.metadata.Hive.createFunction`, `org.apache.hadoop.hive.ql.metadata.Hive.alterFunction`, and `org.apache.hadoop.hive.ql.metadata.Hive.alterFunction` 4. `org.apache.spark.sql.hive.client.VersionsSuite` doesn't have enough test coverage for different hive versions 0.12, 0.13, 0.14, 1.0.0, 1.1.0, 1.2.0. ## How was this patch tested? Unit test. Author: Sean Zhong <seanzhong@databricks.com> Closes #13127 from clockfly/versionSuite. (cherry picked from commit 6e02aec) Signed-off-by: Cheng Lian <lian@databricks.com>
asfgit
pushed a commit
that referenced
this pull request
May 18, 2016
## What changes were proposed in this pull request? This PR fixes a Scala 2.10 compilation failure introduced in PR #13127. ## How was this patch tested? Jenkins build. Author: Cheng Lian <lian@databricks.com> Closes #13166 from liancheng/hotfix-for-scala-2.10. (cherry picked from commit c4a45fd) Signed-off-by: Cheng Lian <lian@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
HiveClient facade is not compatible with Hive 0.12.
This PR Fixes the following compatibility issues:
org.apache.spark.sql.hive.client.HiveClientImpluseAddPartitionDesc(db, table, ignoreIfExists)to create partitions, however, Hive 0.12 doesn't have this constructor forAddPartitionDesc.HiveClientImplusesPartitionDropOptionswhen dropping partition, however, classPartitionDropOptionsdoesn't exist in Hive 0.12.org.apache.hadoop.hive.ql.metadata.Hive.createFunction,org.apache.hadoop.hive.ql.metadata.Hive.alterFunction, andorg.apache.hadoop.hive.ql.metadata.Hive.alterFunctionorg.apache.spark.sql.hive.client.VersionsSuitedoesn't have enough test coverage for different hive versions 0.12, 0.13, 0.14, 1.0.0, 1.1.0, 1.2.0.How was this patch tested?
Unit test.