Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-2386] [SQL] RowWriteSupport should use the exact types to cast. #1315

Closed
wants to merge 3 commits into from

Conversation

ueshin
Copy link
Member

@ueshin ueshin commented Jul 7, 2014

When execute saveAsParquetFile with non-primitive type, RowWriteSupport uses wrong type Int for ByteType and ShortType.

@AmplabJenkins
Copy link

Merged build triggered.

@AmplabJenkins
Copy link

Merged build started.

@AmplabJenkins
Copy link

Merged build triggered.

@AmplabJenkins
Copy link

Merged build started.

@ueshin
Copy link
Member Author

ueshin commented Jul 7, 2014

Added a test for this issue.
Notice that the last commit is not related to this, but should be modified.

@AmplabJenkins
Copy link

Merged build finished. All automated tests passed.

@AmplabJenkins
Copy link

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16368/

@AmplabJenkins
Copy link

Merged build finished. All automated tests passed.

@AmplabJenkins
Copy link

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16369/

asfgit pushed a commit that referenced this pull request Jul 8, 2014
When execute `saveAsParquetFile` with non-primitive type, `RowWriteSupport` uses wrong type `Int` for `ByteType` and `ShortType`.

Author: Takuya UESHIN <ueshin@happy-camper.st>

Closes #1315 from ueshin/issues/SPARK-2386 and squashes the following commits:

20d89ec [Takuya UESHIN] Use None instead of null.
bd88741 [Takuya UESHIN] Add a test.
323d1d2 [Takuya UESHIN] Modify RowWriteSupport to use the exact types to cast.

(cherry picked from commit 4deeed1)
Signed-off-by: Michael Armbrust <michael@databricks.com>
@asfgit asfgit closed this in 4deeed1 Jul 8, 2014
@marmbrus
Copy link
Contributor

marmbrus commented Jul 8, 2014

Thanks, merged into master and 1.0.

xiliu82 pushed a commit to xiliu82/spark that referenced this pull request Sep 4, 2014
When execute `saveAsParquetFile` with non-primitive type, `RowWriteSupport` uses wrong type `Int` for `ByteType` and `ShortType`.

Author: Takuya UESHIN <ueshin@happy-camper.st>

Closes apache#1315 from ueshin/issues/SPARK-2386 and squashes the following commits:

20d89ec [Takuya UESHIN] Use None instead of null.
bd88741 [Takuya UESHIN] Add a test.
323d1d2 [Takuya UESHIN] Modify RowWriteSupport to use the exact types to cast.
kazuyukitanimura pushed a commit to kazuyukitanimura/spark that referenced this pull request Aug 10, 2022
…he#1315)

### What changes were proposed in this pull request?

This PR aims to add a new executor roll policy, FAILED_TASKS.

### Why are the changes needed?

This is helpful to clean up a faulty executor first.

### Does this PR introduce _any_ user-facing change?
Yes, but this is a new feature.

### How was this patch tested?
Pass the CIs.

Closes apache#34938 from williamhyun/SPARK-37679.

Authored-by: William Hyun <william@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
(cherry picked from commit 897f056)
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>

Co-authored-by: William Hyun <william@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants