[SPARK-14346][SQL] Lists unsupported Hive features in SHOW CREATE TABLE output #13173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #58781 has finished for PR 13173 at commit
|
|
Test build #58782 has finished for PR 13173 at commit
|
| "because it contains table structure(s) (e.g. skewed columns) that Spark SQL doesn't " + | ||
| "support yet." | ||
| "which is created by Hive and uses the following feature(s) that are not yet supported " + | ||
| "by Spark SQL:\n" + features.map(" - " + _).mkString("\n") |
There was a problem hiding this comment.
It sounds like that we are missing functionalities. Can we update the error message?
|
Test build #58802 has finished for PR 13173 at commit
|
|
retest this please |
|
Test build #58845 has finished for PR 13173 at commit
|
liancheng
force-pushed
the
spark-14346-follow-up
branch
from
ca22d71
to
925e50a
Compare
|
Test build #58865 has finished for PR 13173 at commit
|
|
Looks good. Merging into master 2.0. |
asfgit
pushed a commit
that referenced
this pull request
May 19, 2016
…LE output ## What changes were proposed in this pull request? This PR is a follow-up of #13079. It replaces `hasUnsupportedFeatures: Boolean` in `CatalogTable` with `unsupportedFeatures: Seq[String]`, which contains unsupported Hive features of the underlying Hive table. In this way, we can accurately report all unsupported Hive features in the exception message. ## How was this patch tested? Updated existing test case to check exception message. Author: Cheng Lian <lian@databricks.com> Closes #13173 from liancheng/spark-14346-follow-up. (cherry picked from commit 6ac1c3a) Signed-off-by: Andrew Or <andrew@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR is a follow-up of #13079. It replaces
hasUnsupportedFeatures: BooleaninCatalogTablewithunsupportedFeatures: Seq[String], which contains unsupported Hive features of the underlying Hive table. In this way, we can accurately report all unsupported Hive features in the exception message.How was this patch tested?
Updated existing test case to check exception message.