Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-15436][SQL] Remove DescribeFunction and ShowFunctions #13292

Closed
wants to merge 2 commits into from

Conversation

rxin
Copy link
Contributor

@rxin rxin commented May 25, 2016

What changes were proposed in this pull request?

This patch removes the last two commands defined in the catalyst module: DescribeFunction and ShowFunctions. They were unnecessary since the parser could just generate DescribeFunctionCommand and ShowFunctionsCommand directly.

How was this patch tested?

Created a new SparkSqlParserSuite.

@rxin
Copy link
Contributor Author

rxin commented May 25, 2016

cc @hvanhovell

@hvanhovell
Copy link
Contributor

LGTM

@SparkQA
Copy link

SparkQA commented May 25, 2016

Test build #59265 has finished for PR 13292 at commit c0af289.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented May 25, 2016

Test build #59266 has finished for PR 13292 at commit 34c0d00.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@hvanhovell
Copy link
Contributor

merging to master & 2.0 thanks!

asfgit pushed a commit that referenced this pull request May 25, 2016
## What changes were proposed in this pull request?
This patch removes the last two commands defined in the catalyst module: DescribeFunction and ShowFunctions. They were unnecessary since the parser could just generate DescribeFunctionCommand and ShowFunctionsCommand directly.

## How was this patch tested?
Created a new SparkSqlParserSuite.

Author: Reynold Xin <rxin@databricks.com>

Closes #13292 from rxin/SPARK-15436.

(cherry picked from commit 4f27b8d)
Signed-off-by: Herman van Hovell <hvanhovell@questtec.nl>
@asfgit asfgit closed this in 4f27b8d May 25, 2016
@rxin rxin deleted the SPARK-15436 branch May 25, 2016 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants