Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-9876] Revert "[SPARK-9876][SQL] Update Parquet to 1.8.1." #13445

Closed
wants to merge 1 commit into from
Closed

[SPARK-9876] Revert "[SPARK-9876][SQL] Update Parquet to 1.8.1." #13445

wants to merge 1 commit into from

Conversation

yhuai
Copy link
Contributor

@yhuai yhuai commented Jun 1, 2016

What changes were proposed in this pull request?

Since we are pretty late in the 2.0 release cycle, it is not clear if this upgrade can be tested thoroughly and if we can resolve the regression issue that we observed before. This PR temporarily reverts #13280. Let's revisit it after the release of 2.0.

How was this patch tested?

Existing tests

This reverts commit 776d183.

@rdblue
Copy link
Contributor

rdblue commented Jun 1, 2016

Sounds reasonable, but the "regression" wasn't located or even confirmed to exist after this change was reverted the last time. There was also no follow-up on it. If we revert the change I suggest that we apply it to master as soon as 2.0 is branched. That way we don't adversely affect 2.0, but we do get this addressed. Is that a reasonable path forward?

@yhuai
Copy link
Contributor Author

yhuai commented Jun 1, 2016

@rdblue Since 2.0 branch has been cut, I am little bit concerned about potential merge conflicts when we cherry-pick bug fixes into 2.0 branch before the release if we do not revert it from the master. We can revisit the upgrade after the release and resolve the regression issue (We will run our benchmark again to check this issue)

@yhuai
Copy link
Contributor Author

yhuai commented Jun 1, 2016

btw, we observed an error when filter pushdown is enabled. Unfortunately, we missed the exception...

@SparkQA
Copy link

SparkQA commented Jun 1, 2016

Test build #59746 has finished for PR 13445 at commit 82812f5.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@yhuai
Copy link
Contributor Author

yhuai commented Jun 1, 2016

@rdblue How about we merge this to master and branch 2.0? Feel free to open your PR again. We can figure out the perf thing with @liancheng together.

@yhuai
Copy link
Contributor Author

yhuai commented Jun 1, 2016

OK. Let me create another PR for branch 2.0. We will merge that one first.

@yhuai
Copy link
Contributor Author

yhuai commented Jun 1, 2016

I am closing this for now.

@yhuai yhuai closed this Jun 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants