[SPARK-15734][SQL] Avoids printing internal row in explain output #13471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clockfly
force-pushed
the
verbose_breakdown_5
branch
from
8ec1684
to
2e679f7
Compare
|
cc @cloud-fan |
|
LGTM |
| override protected def stringArgs = Iterator(output) | ||
| override protected def stringArgs: Iterator[Any] = { | ||
| if (data.isEmpty) { | ||
| Iterator("Empty", output) |
There was a problem hiding this comment.
Just to make sure, do you prefer the following output?
LocalRelation EmptyRelation, [_1#58,_2#59,_3#60]
Instead of
LocalRelation Empty, [_1#58,_2#59,_3#60]
There was a problem hiding this comment.
Good point... How about just ""? Both "Empty" and "EmptyRelation" look like some class name, while "" reads more like an annotation. (This is pretty subjective though.)
|
LGTM except for minor naming issue. |
|
Test build #59867 has finished for PR 13471 at commit
|
|
Test build #59874 has finished for PR 13471 at commit
|
|
Merging to master and branch-2.0. |
asfgit
pushed a commit
that referenced
this pull request
Jun 2, 2016
## What changes were proposed in this pull request?
This PR avoids printing internal rows in explain output for some operators.
**Before change:**
```
scala> (1 to 10).toSeq.map(_ => (1,2,3)).toDF().createTempView("df3")
scala> spark.sql("select * from df3 where 1=2").explain(true)
...
== Analyzed Logical Plan ==
_1: int, _2: int, _3: int
Project [_1#37,_2#38,_3#39]
+- Filter (1 = 2)
+- SubqueryAlias df3
+- LocalRelation [_1#37,_2#38,_3#39], [[0,1,2,3],[0,1,2,3],[0,1,2,3],[0,1,2,3],[0,1,2,3],[0,1,2,3],[0,1,2,3],[0,1,2,3],[0,1,2,3],[0,1,2,3]]
...
== Physical Plan ==
LocalTableScan [_1#37,_2#38,_3#39]
```
**After change:**
```
scala> spark.sql("select * from df3 where 1=2").explain(true)
...
== Analyzed Logical Plan ==
_1: int, _2: int, _3: int
Project [_1#58,_2#59,_3#60]
+- Filter (1 = 2)
+- SubqueryAlias df3
+- LocalRelation [_1#58,_2#59,_3#60]
...
== Physical Plan ==
LocalTableScan <empty>, [_1#58,_2#59,_3#60]
```
## How was this patch tested?
Manual test.
Author: Sean Zhong <seanzhong@databricks.com>
Closes #13471 from clockfly/verbose_breakdown_5.
(cherry picked from commit 985d532)
Signed-off-by: Cheng Lian <lian@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR avoids printing internal rows in explain output for some operators.
Before change:
After change:
How was this patch tested?
Manual test.