[SPARK-15766][SparkR]:R should export is.nan #13508
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #59984 has finished for PR 13508 at commit
|
|
@felixcheung As we discussed, I opened a JIRA on exporting the is.nan. Can you review it? Thanks! |
|
don't we need to for Line 651 in d642b27 this is different from isNaN
|
|
Test build #60022 has finished for PR 13508 at commit
|
|
Test build #60023 has finished for PR 13508 at commit
|
|
@felixcheung Add isnan in the NAMESPACE file. |
|
Thanks @wangmiao1981 - LGTM. Merging this to master and branch-2.0 |
asfgit
pushed a commit
that referenced
this pull request
Jun 10, 2016
## What changes were proposed in this pull request? When reviewing SPARK-15545, we found that is.nan is not exported, which should be exported. Add it to the NAMESPACE. ## How was this patch tested? Manual tests. Author: wm624@hotmail.com <wm624@hotmail.com> Closes #13508 from wangmiao1981/unused. (cherry picked from commit 2c8f40c) Signed-off-by: Shivaram Venkataraman <shivaram@cs.berkeley.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When reviewing SPARK-15545, we found that is.nan is not exported, which should be exported.
Add it to the NAMESPACE.
How was this patch tested?
Manual tests.