[SPARK-15788][PYSPARK][ML] PySpark IDFModel missing "idf" property

[zjffdu]

What changes were proposed in this pull request?

add method idf to IDF in pyspark

How was this patch tested?

add unit test

[SparkQA]

Test build #60116 has finished for PR 13540 at commit e5c11da.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[BryanCutler]

Good catch! Not too big of deal, but should this be a property? Otherwise, LGTM
cc @MLnick

[MechCoder]

LGTM as well. pending the nitpick by @BryanCutler

Not related, but it's been a while since I hacked on Spark or PySpark but at some point do we need better docs for PySpark? I couldn't figure out how the IDF's are calculated without looking at the Scala documentation.

[MLnick]

We should make it a property
On Tue, 7 Jun 2016 at 11:28, Manoj Kumar notifications@github.com wrote:

LGTM as well. pending the nitpick by @BryanCutler
https://github.com/BryanCutler

Not related, but it's been a while since I hacked on Spark or PySpark but
at some point do we need better docs for PySpark? I couldn't figure out how
the IDF's are calculated without looking at the Scala documentation.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#13540 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AA_SB_BQRxelQdfaS3wy5ld9p8efsmwnks5qJbhpgaJpZM4IvqPP
.

[MLnick]

Also, yes we should actually look at copying docs from Scala side where
appropriate. We can add that to the QA JIRAs for Python doc.

On Tue, 7 Jun 2016 at 11:28, Manoj Kumar notifications@github.com wrote:

LGTM as well. pending the nitpick by @BryanCutler
https://github.com/BryanCutler

Not related, but it's been a while since I hacked on Spark or PySpark but
at some point do we need better docs for PySpark? I couldn't figure out how
the IDF's are calculated without looking at the Scala documentation.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#13540 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AA_SB_BQRxelQdfaS3wy5ld9p8efsmwnks5qJbhpgaJpZM4IvqPP
.

[zjffdu]

Thanks @BryanCutler @MechCoder @MLnick for the review. I just update the PR to make it as property. Regarding the pyspark docs, I think there's umbrella jira to parity scala mllib and pyspark mllib, we can create sub task there.

[SparkQA]

Test build #60145 has finished for PR 13540 at commit d1c00da.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[MLnick]

LGTM