[SPARK-15884][SparkR][SQL] Overriding stringArgs in MapPartitionsInR #13610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NarineK
changed the title
|
Thanks @NarineK - Change looks pretty good to me. Minor comment: Can you update the title to have |
|
LGTM pending Jenkins, and the PR title change. Thanks! |
NarineK
changed the title
|
Thanks! Changed the title! |
NarineK
changed the title
NarineK
changed the title
|
Test build #60318 has finished for PR 13610 at commit
|
|
Merging to master and branch-2.0. Thanks! |
asfgit
pushed a commit
that referenced
this pull request
Jun 11, 2016
## What changes were proposed in this pull request? As discussed in #12836 we need to override stringArgs method in MapPartitionsInR in order to avoid too large strings generated by "stringArgs" method based on the input arguments. In this case exclude some of the input arguments: serialized R objects. ## How was this patch tested? Existing test cases Author: Narine Kokhlikyan <narine.kokhlikyan@gmail.com> Closes #13610 from NarineK/dapply_MapPartitionsInR_stringArgs. (cherry picked from commit 54f758b) Signed-off-by: Cheng Lian <lian@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
As discussed in #12836
we need to override stringArgs method in MapPartitionsInR in order to avoid too large strings generated by "stringArgs" method based on the input arguments.
In this case exclude some of the input arguments: serialized R objects.
How was this patch tested?
Existing test cases