[SPARK-15977][SQL] Fix TRUNCATE TABLE for Spark specific datasource tables #13697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @andrewor14 |
|
LGTM |
|
Test build #60617 has finished for PR 13697 at commit
|
|
Test build #3116 has finished for PR 13697 at commit
|
|
Test build #60633 has finished for PR 13697 at commit
|
|
new changes also LGTM. It's weird that we just implicitly assume the location must be |
|
Merging to master/2.0 - thanks for the review! |
asfgit
pushed a commit
that referenced
this pull request
Jun 16, 2016
…ables ## What changes were proposed in this pull request? `TRUNCATE TABLE` is currently broken for Spark specific datasource tables (json, csv, ...). This PR correctly sets the location for these datasources which allows them to be truncated. ## How was this patch tested? Extended the datasources `TRUNCATE TABLE` tests in `DDLSuite`. Author: Herman van Hovell <hvanhovell@databricks.com> Closes #13697 from hvanhovell/SPARK-15977. (cherry picked from commit f9bf15d) Signed-off-by: Herman van Hovell <hvanhovell@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
TRUNCATE TABLEis currently broken for Spark specific datasource tables (json, csv, ...). This PR correctly sets the location for these datasources which allows them to be truncated.How was this patch tested?
Extended the datasources
TRUNCATE TABLEtests inDDLSuite.