[SPARK-15916][SQL] JDBC filter push down should respect operator precedence #13743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #60729 has finished for PR 13743 at commit
|
|
LGTM |
|
Merging to master and branch-2.0. |
asfgit
pushed a commit
that referenced
this pull request
Jun 18, 2016
…edence
## What changes were proposed in this pull request?
This PR fixes the problem that the precedence order is messed when pushing where-clause expression to JDBC layer.
**Case 1:**
For sql `select * from table where (a or b) and c`, the where-clause is wrongly converted to JDBC where-clause `a or (b and c)` after filter push down. The consequence is that JDBC may returns less or more rows than expected.
**Case 2:**
For sql `select * from table where always_false_condition`, the result table may not be empty if the JDBC RDD is partitioned using where-clause:
```
spark.read.jdbc(url, table, predicates = Array("partition 1 where clause", "partition 2 where clause"...)
```
## How was this patch tested?
Unit test.
This PR also close #13640
Author: hyukjinkwon <gurwls223@gmail.com>
Author: Sean Zhong <seanzhong@databricks.com>
Closes #13743 from clockfly/SPARK-15916.
(cherry picked from commit ebb9a3b)
Signed-off-by: Cheng Lian <lian@databricks.com>
zzcclp
added a commit
to zzcclp/spark
that referenced
this pull request
Jul 27, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR fixes the problem that the precedence order is messed when pushing where-clause expression to JDBC layer.
Case 1:
For sql
select * from table where (a or b) and c, the where-clause is wrongly converted to JDBC where-clausea or (b and c)after filter push down. The consequence is that JDBC may returns less or more rows than expected.Case 2:
For sql
select * from table where always_false_condition, the result table may not be empty if the JDBC RDD is partitioned using where-clause:How was this patch tested?
Unit test.
This PR also close #13640