-
Notifications
You must be signed in to change notification settings - Fork 28.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-16174][SQL] Improve OptimizeIn
optimizer to remove literal repetitions
#13876
Closed
Closed
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
74d107d
[SPARK-16174][SQL] Add RemoveLiteralRepetitionFromIn optimizer
dongjoon-hyun 779ade8
Merge into OptimizeIn optimizer and handle all deterministic cases.
dongjoon-hyun e99fa4a
Change testcase name and fix typo.
dongjoon-hyun 4f54c64
Update optimizer descriptions.
dongjoon-hyun 6628c7b
According to SPARK-16081, replace `l` with `list`.
dongjoon-hyun 314bc74
Simplify the logic to handle only all-deterministic cases.
dongjoon-hyun 23d6e30
Add lazy val.
dongjoon-hyun 125036a
Rename variable.
dongjoon-hyun 63a4a79
Optimize only literals.
dongjoon-hyun ccf972d
Fix regression.
dongjoon-hyun f068e4b
Replace `copy`.
dongjoon-hyun eead3db
Fix again.
dongjoon-hyun File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, here is regression. Originally,
v
could be non-deterministic.