[SPARK-16328][ML][MLLIB][PYSPARK] Add 'asML' and 'fromML' conversion methods to PySpark linalg #13997
Conversation
MLnick
changed the title
|
Test build #61544 has finished for PR 13997 at commit
|
| :param vec: a :py:class:`pyspark.ml.linalg.Vector` | ||
| :return: a :py:class:`pyspark.mllib.linalg.Vector` | ||
| """ | ||
| if type(vec) == newlinalg.DenseVector: |
There was a problem hiding this comment.
It's a common pythonic practise to use isinstance in such cases. If vec is an instance of something that inherits from DenseVector, then this check will fail.
There was a problem hiding this comment.
doh! yeah of course, wasn't thinking. Thanks!
|
LGTM pending nitpicks. |
|
Test build #61556 has finished for PR 13997 at commit
|
| True | ||
|
|
||
| :param vec: a :py:class:`pyspark.ml.linalg.Vector` | ||
| :return: a :py:class:`pyspark.mllib.linalg.Vector` |
|
Looks good, except for a few minor comments |
|
@jkbradley fair point for the tests - I actually just moved them to |
|
Test build #61572 has finished for PR 13997 at commit
|
|
Thanks for the updates! For tests, I'm all for including some doc tests in Python if they provide good examples for the docs. But developers, myself included, have tended to include too much in doc tests in the past. LGTM |
…methods to PySpark linalg The move to `ml.linalg` created `asML`/`fromML` utility methods in Scala/Java for converting between representations. These are missing in Python, this PR adds them. ## How was this patch tested? New doctests. Author: Nick Pentreath <nickp@za.ibm.com> Closes #13997 from MLnick/SPARK-16328-python-linalg-convert. (cherry picked from commit dab1051) Signed-off-by: Joseph K. Bradley <joseph@databricks.com>
The move to
ml.linalgcreatedasML/fromMLutility methods in Scala/Java for converting between representations. These are missing in Python, this PR adds them.How was this patch tested?
New doctests.